Feat: introduce accessType property in a share and remove the datatx "protocol" #307
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mickenordin
previously approved these changes
Dec 8, 2025
Member
mickenordin
left a comment
mickenordin
left a comment
There was a problem hiding this comment.
Very good, one thing I wonder is if we should mention in the text is that datatx without an expiration is intended for sync like use cases?
Member
Author
Good point, why not. And even reinforce that What about deprecating the |
mickenordin
approved these changes
Dec 9, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Following discussions last week at the SIG-CISS meeting, this PR implements the following:
accessTypeproperty inside thewebdavprotocol, with valuesremoteanddatatx(defaults toremote)datatxas protocol, in favor of the aboveThe rationale is that data transfers are "orthogonal" to the underlying transport protocol, especially if we think about other possible protocols (another companion PR is coming next).
Some comments:
datatxas protocol on the basis that it's not used in any production setup (as far as I know, the only implementation is in Reva but I may be wrong). If people prefer an official deprecation, that's also fine.